Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14688 )
Change subject: IMPALA-9127: explicit probe state machine in hash join ...................................................................... Patch Set 8: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.h@86 PS8, Line 86: that in that are used in? http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.h@404 PS8, Line 404: ProbeState* next_state Might be nice to make this a 'bool* done' instead, to be consistent with the methods below and to keep all of the places where we set the ProbeState completely contained in GetNext(). Not a big deal, though http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.h@421 PS8, Line 421: probe_state_ nit: 'probe_state_' http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.cc@57 PS8, Line 57: state_(HashJoinState::PARTITIONING_BUILD), Any reason not to just put this initialization the header? http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.cc@1134 PS8, Line 1134: DCHECK_EQ(probe_batch_pos_, -1); DCHECK_ENUM_EQ(probe_state_, ProbeState::PROBING_END_BATCH)?} http://gerrit.cloudera.org:8080/#/c/14688/8/be/src/exec/partitioned-hash-join-node.cc@1141 PS8, Line 1141: DCHECK DCHECK_ENUM_EQ -- To view, visit http://gerrit.cloudera.org:8080/14688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ebdf0054d2ce4562b851439e300323601fb064 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Nov 2019 18:50:22 +0000 Gerrit-HasComments: Yes
