Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065: Add OS distribution name in OSInfo ...................................................................... IMPALA-8065: Add OS distribution name in OSInfo Before this change OsInfo::DebugString() would print two lines: - OS version: the long name of the Linux kernel from /proc/version - Clock: the type of clock used After this change OsInfo::DebugString() will print three lines: - OS distribution: the short name of the OS release. If Docker is being used this is the name of the Container OS. - OS version: the long name of the Linux kernel from /proc/version. If Docker is being used this is the description of the Host Kernel. - Clock: the type of clock used. Tested locally, the displayed OS Info in Ubuntu16 dev box is: OS distribution: Ubuntu 16.04.6 LTS OS version: Linux version 4.15.0-65-generic (buildd@lcy01-amd64-017) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)) Clock: clocksource: 'tsc', clockid_t: CLOCK_MONOTONIC Also checked with diff OS in docker: centos, redhat, ubuntu, oracle, debian to make sure /etc/os-release exists and PRETTY_NAME in that file. Each OS picked one version to test. Specially for centos6 and redhat6, which have redhat-release instead of os-release, copied redhat-release into Ubuntu16 dev box and verified os version in mini-cluster. Added new backend test os-info-test.cc. Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Reviewed-on: http://gerrit.cloudera.org:8080/14531 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/util/CMakeLists.txt A be/src/util/os-info-test.cc M be/src/util/os-info.cc M be/src/util/os-info.h 4 files changed, 82 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 12 Gerrit-Owner: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com>