Hello Michael Ho, Lars Volker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14755
to look at the new patch set (#4).
Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring
......................................................................
IMPALA-9124: ImpalaServer and ClientRequestState refactoring
Re-factoring several areas of the ImpalaServer and ClientRequestState
in preparation for future work required for transparent query retries.
Re-factored TExecRequest ownership in ClientRequestState. Previously,
the TExecRequest was passed to the ClientRequestState via the
Exec(TExecRequest) method. Now it is created and owned by the
ClientRequestState and only exposed as a constant reference. It is
stored as a plain member variable.
Re-factored ImpalaServer::UnregisterQuery into multiple methods. Made
ClientRequestStateMap a dedicated class that extends ShardedQueryMap
with additional methods to add and delete a ClientRequestState. The
re-factoring breaks up the large UnregisterQuery method into multiple
smaller method and adds some additional code documentation.
Re-factored ImpalaHttpHandler's usage of the ClientRequestStateMap so
that it tracks its own list of running query ids / ClientRequestStates
rather than using the one owned by ImpalaServer. This is particularly
important for transparent query retries because retrying a query causes
duplicate ClientRequestStates to be added to the
ImpalaServer::client_request_state_map_.
Testing:
* Ran core tests
Change-Id: Ib92c932a69802225af3fd9bf15f85c85317acaca
---
A be/src/service/client-request-state-map.h
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
7 files changed, 179 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/14755/4
--
To view, visit http://gerrit.cloudera.org:8080/14755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib92c932a69802225af3fd9bf15f85c85317acaca
Gerrit-Change-Number: 14755
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
