Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/14705/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14705/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@332 PS1, Line 332: default 0 > What if try to set the default value to something that goes beyond the limi The expected behavior must be an error. http://gerrit.cloudera.org:8080/#/c/14705/1/impala-parent/pom.xml File impala-parent/pom.xml: http://gerrit.cloudera.org:8080/#/c/14705/1/impala-parent/pom.xml@48 PS1, Line 48: <kudu.version>1.12.0-SNAPSHOT</kudu.version> > Why to hard-code the version in here? Sorry, it's a mistake. This file must not be committed. http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@155 PS1, Line 155: date > Do we expect to use Date type columns as a part of primary key? If so, may Yes, we expect Date type columns to be a part of primary key. New test will be added. http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test: http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test@14 PS1, Line 14: 1970-01-05 > Does it make sense to add a scenario to test for pre-epoch timestamps? E.g Such example is present in kudu_upsert.test. -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 1 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Nov 2019 04:28:58 +0000 Gerrit-HasComments: Yes
