Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 )
Change subject: IMPALA-4080: [Part 1] Move static state from ExecNode into a PlanNode ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/aggregation-node-base.h File be/src/exec/aggregation-node-base.h: http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/aggregation-node-base.h@50 PS4, Line 50: /// If true, the input to this node should be passed into each Aggregator in 'aggs_'. > line too long (109 > 90) Done http://gerrit.cloudera.org:8080/#/c/14764/3/be/src/exec/aggregation-node-base.h File be/src/exec/aggregation-node-base.h: http://gerrit.cloudera.org:8080/#/c/14764/3/be/src/exec/aggregation-node-base.h@43 PS3, Line 43: const PlanNode& pnode > This is going to be an annoying nitpick, but I think it should be a const r Done http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/exec-node.h File be/src/exec/exec-node.h: http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/exec-node.h@356 PS4, Line 356: /// state is move there and accessed directly. > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/exec-node.cc@217 PS4, Line 217: row_descriptor_(*(pnode.row_descriptor_)), > line too long (160 > 90) Done http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/partitioned-hash-join-node.cc@82 PS4, Line 82: Status PartitionedHashJoinPlanNode::CreateNode( > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/union-node.cc File be/src/exec/union-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/4/be/src/exec/union-node.cc@73 PS4, Line 73: first_materialized_child_idx_(pnode.tnode_->union_node.first_materialized_child_idx), > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/14764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69f1676bf67bac31fa5902511b3fcc269fd67472 Gerrit-Change-Number: 14764 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Nov 2019 00:21:43 +0000 Gerrit-HasComments: Yes
