Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14756 )
Change subject: IMPALA-9151: Maintain cluster size in ExecutorMembershipSnapshot ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14756/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/14756/2/be/src/runtime/exec-env.cc@198 PS2, Line 198: if (!group) return; > I think this lack of updating needs some explanation - the implications are I went with your suggestion and I think it looks good. -- To view, visit http://gerrit.cloudera.org:8080/14756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b05326c82fb3ca625c015cfcdc38f891f5d4f9 Gerrit-Change-Number: 14756 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Nov 2019 01:07:45 +0000 Gerrit-HasComments: Yes
