Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743 PS7, Line 743: self.assert_impalad_log_contains > This is all a little brittle cause when you run a test cluster with start-i Oh yeah, the dockerised case is another good point. Most of the assert_impalad_log_contains uses are for custom cluster tests, which start a new cluster just for that test. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Nov 2019 19:36:28 +0000 Gerrit-HasComments: Yes
