Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14714 )
Change subject: IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3 ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14714/5/be/src/runtime/datetime-iso-sql-format-parser.cc File be/src/runtime/datetime-iso-sql-format-parser.cc: http://gerrit.cloudera.org:8080/#/c/14714/5/be/src/runtime/datetime-iso-sql-format-parser.cc@297 PS5, Line 297: if (tok.type == MONTH_NAME && fx_provided && !tok.fm_modifier) { : if (input_len < MAX_MONTH_NAME_LENGTH) return nullptr; : return input_str + MAX_MONTH_NAME_LENGTH; : } > If there is no following separator then the month name token will have the Thanks! http://gerrit.cloudera.org:8080/#/c/14714/5/be/src/runtime/datetime-parser-common.h File be/src/runtime/datetime-parser-common.h: http://gerrit.cloudera.org:8080/#/c/14714/5/be/src/runtime/datetime-parser-common.h@70 PS5, Line 70: {"dec", {"ember", 12}} : }; : > Being a bit more specific here would help. What I meant was that it is a bit confusing that the comment says "Mapping between textual month name and the number of month" while the name of the map is 'MONTH_PREFIX_TO_SUFFIX'. -- To view, visit http://gerrit.cloudera.org:8080/14714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f Gerrit-Change-Number: 14714 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Nov 2019 14:31:39 +0000 Gerrit-HasComments: Yes
