Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14820 )
Change subject: IMPALA-9211: Fix adding new table to stale db due to concurrent reset ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1737 PS1, Line 1737: return db.getTable(tblName); Is is necessary to keep the lock during getTable() too? The name is a bit misleading, as it also loads the table if it is an IncompleteTable (which is true in this case). The RPC to HMS makes it a potentially expensive call, and it would be better to avoid locking the whole catalog during the call. -- To view, visit http://gerrit.cloudera.org:8080/14820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83d2e5f00eabe61a42c948ec1685ce29cdea1592 Gerrit-Change-Number: 14820 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Dec 2019 14:57:58 +0000 Gerrit-HasComments: Yes
