Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14755 )

Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring
......................................................................


Patch Set 9: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h
File be/src/service/client-request-state.h:

http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@231
PS5, Line 231:   /// Contents are only valid after InitExecRequest(TQueryCtx) 
initializes the
> I'm actually about to change this again in an upcoming patch, so I'm not su
Sounds good, let's defer



--
To view, visit http://gerrit.cloudera.org:8080/14755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib92c932a69802225af3fd9bf15f85c85317acaca
Gerrit-Change-Number: 14755
Gerrit-PatchSet: 9
Gerrit-Owner: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 17:51:35 +0000
Gerrit-HasComments: Yes

Reply via email to