Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14790 )
Change subject: IMPALA-9126: part 4: hash join builder manages spilling ...................................................................... Patch Set 8: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-builder.h@200 PS8, Line 200: when *repartitioning as true I think this is supposed to be "when *repartitioned is true"? http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-builder.h@213 PS8, Line 213: repartitioning same - repartitioned? http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-builder.cc@641 PS8, Line 641: Pick the next spilled partition the input partition will stay in : // 'spilled_partitions_' until we are done probing it or repartitioning its probe. Having some trouble parsing this sentence. I think you missed a period after "Pick the next spilled partition"? http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: http://gerrit.cloudera.org:8080/#/c/14790/8/be/src/exec/partitioned-hash-join-node.cc@1098 PS8, Line 1098: // The build partitions we need to retain for further processing. stale -- To view, visit http://gerrit.cloudera.org:8080/14790 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6de5f62e3eacf80f72c8ea0ed8cba012f0f53c90 Gerrit-Change-Number: 14790 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Dec 2019 19:35:15 +0000 Gerrit-HasComments: Yes
