Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 )
Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState ...................................................................... Patch Set 9: I'm not entirely sure why, but the original version of the test_error_query_state turned out to be flaky. Sometimes the profile would already be in an ERROR state before the client fetches any rows (perhaps that is expected behavior, not sure). I change it so that the query runs with a debug action and fails whenever the scan node calls GETNEXT, which should be more reliable. I also made a bug fix to the tests. Originally the tests used the following asserts: assert "Query State: RUNNING" in profile assert "Impala Query State: RUNNING" in profile The issue is that the asserts are redundant since 'Query State: RUNNING' is inside the string 'Impala Query State: RUNNING'. I fixed this using regexes to anchor the search string at the beginning of a line. -- To view, visit http://gerrit.cloudera.org:8080/14744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce70bd2e964b309ebfc9d6ff6d900485db4d630 Gerrit-Change-Number: 14744 Gerrit-PatchSet: 9 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <michael...@gmail.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Dec 2019 15:34:26 +0000 Gerrit-HasComments: No
