wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 )
Change subject: IMPALA-8984: Fix race condition in creating Kudu table ...................................................................... Patch Set 13: > (1 comment) Lock both kudu table creation and hms table creation by 'DdlLock_' can certainly solve this problem, but maybe to heavy. It doesn't matter that KuduCatalogOpExecutor.createManagedTable is not thread-safey, because the root reason for this bug is: create table in hms failed(first query already created) caused an exception which lead to table delete in kudu storage(line 2254). Even two threads create table in kudu stoage at the same time, kudu provide guarantee to this situation, and it's doesn't matter which query created table in kudu finally. So I just add the code to check whether table already exist in hms. -- To view, visit http://gerrit.cloudera.org:8080/14319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a4047bcdaa6b346765b96e8c36bb747a2b0091d Gerrit-Change-Number: 14319 Gerrit-PatchSet: 13 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Fri, 13 Dec 2019 03:21:45 +0000 Gerrit-HasComments: No
