Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14904 )
Change subject: IMPALA-9231: support simplified privilege checks for SHOW DATABASES ...................................................................... Patch Set 1: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/14904/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14904/1/fe/src/main/java/org/apache/impala/service/Frontend.java@943 PS1, Line 943: Privilege requiredPrivilege = Privilege.ANY; : if (BackendConfig.INSTANCE.simplifyCheckOnShowDbsAndTables()) { : requiredPrivilege = Privilege.SELECT; : } There could be a function for this like RequiredPrivilegeForShowDbsAndTables(); http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@547 PS1, Line 547: root_impalad_client, "show databases", user=another_user) nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@557 PS1, Line 557: "drop database if exists db_%s_%s cascade" % (unique_name, priv)) nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/14904/1/tests/authorization/test_authorization.py@597 PS1, Line 597: "drop database if exists db_%s_%s cascade" % (unique_name, priv)) nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/14904 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I631fc5c386a52f0a1f62182473be15fcc3dd8609 Gerrit-Change-Number: 14904 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Dec 2019 17:01:13 +0000 Gerrit-HasComments: Yes