Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14885 )
Change subject: IMPALA-8891: concat_ws() null handling is non-standard ...................................................................... Patch Set 7: (6 comments) Thanks for addressing on the code style comments! Still have few. The patch looks good to me overall. http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4666 PS7, Line 4666: , nit: need space http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4667 PS7, Line 4667: , nit: need space http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4668 PS7, Line 4668: , nit: need space http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4669 PS7, Line 4669: , nit: need space http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4670 PS7, Line 4670: , nit: need space http://gerrit.cloudera.org:8080/#/c/14885/7/be/src/exprs/expr-test.cc@4671 PS7, Line 4671: , nit: need space -- To view, visit http://gerrit.cloudera.org:8080/14885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cd3bfbb952e431a0cf52a5835ac05d2513d29b Gerrit-Change-Number: 14885 Gerrit-PatchSet: 7 Gerrit-Owner: jichen <ji.c...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: jichen <ji.c...@cloudera.com> Gerrit-Comment-Date: Sat, 14 Dec 2019 13:41:43 +0000 Gerrit-HasComments: Yes
