Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14894/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14894/6//COMMIT_MSG@32 PS6, Line 32: - CreateView and AlterView statements on masked tables/views are not : dealt with in this patch, since the rewritten AST may not be able to : generate sql without syntax errors (e.g. missing alias). Just realize that we don't need to rewrite statements for table masking for CreateView and AlterView. The table masking will happen when the view is used. Will update the patch for this. -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Dec 2019 00:08:16 +0000 Gerrit-HasComments: Yes
