Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 )
Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/14846/7/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14846/7/fe/src/main/java/org/apache/impala/service/Frontend.java@859 PS7, Line 859: d(dbNa > Using MoreExecutors.sameThreadExecutor seems much better. About tests: yes, tests/authorization/test_authorization.py is a good place to add a test for this new flag. All the tests there are "custom cluster tests", so they will restart the impala deamons with flags specified in "impalad_args". http://gerrit.cloudera.org:8080/#/c/14846/9/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14846/9/fe/src/main/java/org/apache/impala/service/Frontend.java@866 PS9, Line 866: new CheckAuthorization(dbName, tblName, tableOwner, user))); nit: +2 indentation http://gerrit.cloudera.org:8080/#/c/14846/9/fe/src/main/java/org/apache/impala/service/Frontend.java@997 PS9, Line 997: new CheckAuthorization(db.getName(), null, db.getOwnerUser(), user))); nit: +2 indentation -- To view, visit http://gerrit.cloudera.org:8080/14846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I860e0d18afa0421665f8b3b1c5561d6bdacc5e96 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 9 Gerrit-Owner: Zhou Xu <peter.cose....@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zhou Xu <peter.cose....@gmail.com> Gerrit-Comment-Date: Wed, 18 Dec 2019 13:35:17 +0000 Gerrit-HasComments: Yes
