David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14924 )
Change subject: IMPALA-9240: add HTTP code handling to THttpClient. ...................................................................... Patch Set 1: (1 comment) Looks good to me, overall. Just one small comment from me. http://gerrit.cloudera.org:8080/#/c/14924/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14924/1/tests/shell/test_shell_interactive.py@868 PS1, Line 868: return I feel like this should be pytest.skip(). I think using return here will mean that this shows up as a passing test, even if it didn't run. -- To view, visit http://gerrit.cloudera.org:8080/14924 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c105f4b8237b87695324d759ffff81821c08c43 Gerrit-Change-Number: 14924 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 18 Dec 2019 21:23:27 +0000 Gerrit-HasComments: Yes
