Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14973 )
Change subject: IMPALA-9274: cyclic barrier implementation ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h File be/src/util/cyclic-barrier.h: http://gerrit.cloudera.org:8080/#/c/14973/4/be/src/util/cyclic-barrier.h@61 PS4, Line 61: barrier_cv_.NotifyAll(); > Yeah, I opened a Jira for this: IMPALA-6135 I see now (actually I don't know why I thought that it would make a difference :-/ ) Performance is a good question, I guess it is implementation dependent whether this matters. -- To view, visit http://gerrit.cloudera.org:8080/14973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5c8cc6b3023d2dc03c8116d462440c5e25c3bb0 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jan 2020 15:01:01 +0000 Gerrit-HasComments: Yes
