Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 )
Change subject: IMPALA-9010: Add builtin mask functions ...................................................................... Patch Set 2: Code-Review+1 (4 comments) That seems a lot of work, nice job! Added some small comments, otherwise lgtm. http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/expr-test.cc@10449 PS2, Line 10449: // Error handling What happens when one would mask the day in 2019-02-02 to 30? Could you add a test for it here? http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions-ir.cc@223 PS2, Line 223: !(1 <= day_value && day_value <= 31) This considers 31 as a valid day number for eg. February. Shouldn't this be checked here? What is the behaviour of Hive? http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions-ir.cc@266 PS2, Line 266: 4 Wouldn't it be nicer if this constant were defined at the beginning of the file with the other constants? It appears here and many times below. http://gerrit.cloudera.org:8080/#/c/14963/2/be/src/exprs/mask-functions-ir.cc@697 PS2, Line 697: (void)SHA256(val.ptr, val.len, sha256_hash.ptr); nit: Wouldn't using "discard_result" be nicer here? -- To view, visit http://gerrit.cloudera.org:8080/14963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica779a1bf63a085d51f3b533f654cbaac102a664 Gerrit-Change-Number: 14963 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jan 2020 15:52:01 +0000 Gerrit-HasComments: Yes
