Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14998
to look at the new patch set (#3).
Change subject: IMPALA-6393 live_summary and live_progress are not supported in
impalarc
......................................................................
IMPALA-6393 live_summary and live_progress are not supported in impalarc
The internal variables for live_summary and live_progress are defined as
print_summary
and print_progress in impala_shell. When reading configuration parameters
from the
config file, it save configurations as dictionary with external name as key.
This cause live_summary and live_progress in impalarc do not take effect in
impala_shell.
To fix the issue, change internal variable names same as external names for
option
live_summary and live_progress.
Add some unit-test cases in test_shell_commandline.py and
test_shell_interactive.py
for option live_summary and live_progress read from impalarc.
Unit test:
1) manually verified live_summary and live_progress are supported in
impalarc
2) passed all test cases for tests/shell/test_shell_interactive.py and
tests/shell/test_shell_commandline.py
Change-Id: I68e7ac008729fc30fd5d67ec973231334c68be9d
---
M bin/rat_exclude_files.txt
M shell/impala_shell.py
M shell/impala_shell_config_defaults.py
M shell/option_parser.py
A tests/shell/good_impalarc3
A tests/shell/good_impalarc4
A tests/shell/impalarc_with_error2
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
9 files changed, 93 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/14998/3
--
To view, visit http://gerrit.cloudera.org:8080/14998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68e7ac008729fc30fd5d67ec973231334c68be9d
Gerrit-Change-Number: 14998
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
