Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 15: (2 comments) Changes: Fix a bug in FromClause#reset() that I forget to migrate join properties back to the unmasked table. http://gerrit.cloudera.org:8080/#/c/14894/13/fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java: http://gerrit.cloudera.org:8080/#/c/14894/13/fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java@49 PS13, Line 49: // Disable table masking since we don't actually read the data. > nit: missing . Done http://gerrit.cloudera.org:8080/#/c/14894/13/fe/src/main/java/org/apache/impala/analysis/FromClause.java File fe/src/main/java/org/apache/impala/analysis/FromClause.java: http://gerrit.cloudera.org:8080/#/c/14894/13/fe/src/main/java/org/apache/impala/analysis/FromClause.java@116 PS13, Line 116: * sure we get the same results in later resolution, the unresolved tableRefs should : * use fully qualified paths. Otherwise, non-fully qualified paths might incorrectly : * match a local view. : * However, we don't un-resolve views because local views don't have fully qualified : * paths. Due to this we don't unmask a TableMasking view if the underlying > The new origTblRef will only overwrite the old one in line 130, so it needs origTblRef can be InlineViewRef after unmasking if it's a TableRef for a view (either local views in WITH-clause or catalog view). If it's a view after unmasking we don't replace it with a unresolved one. I spent a lot of time understanding this part (why except views) and updated the comments. Also refactor this function into clearly two parts: unmasking and 'un-resolving'. Here also has a bug that if we unmask the table, we forget to migrate back the join properties. Added test coverage for this. -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Jan 2020 11:40:32 +0000 Gerrit-HasComments: Yes
