Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15072 )
Change subject: IMPALA-9265: Support for toolchain Kudu to provide Java artifacts ...................................................................... Patch Set 2: Took a first pass through it, it looks pretty good. There is one issue that makes me wonder: 1.we explicitly include the C/C++ compiler version in the resulting tarballs' name 2. We now start including Java binaries in the same tarballs. Java binaries can (in theory at least, if not in current practice) be produced by different JDK versions, so should we start including the JDK version (or distro+version) string in the artifact names? Currently we build only with JDK 8, but as JDK 8 is nearing its End of Support Date, this may change one day. We can also defer the decision and establish the convention that no explicit Java version means JDK 8, and everything else is marked; this can be left to our future selves. -- To view, visit http://gerrit.cloudera.org:8080/15072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba03dfe9c302513b825cbed7146c582e7d97c3af Gerrit-Change-Number: 15072 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Jan 2020 22:11:07 +0000 Gerrit-HasComments: No
