Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15023 )
Change subject: IMPALA-9075: Add support for reading zstd text files ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15023/4/be/src/util/decompress.cc File be/src/util/decompress.cc: http://gerrit.cloudera.org:8080/#/c/15023/4/be/src/util/decompress.cc@665 PS4, Line 665: *stream_end = false; It seems to me that this line is redundant. *stream_end = true is only set if (input_buffer.pos == input_buffer.size) in which case we will break out of the loop. -- To view, visit http://gerrit.cloudera.org:8080/15023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2adce9fe00190558525fa5cd3d50cf5e0f0b0aa4 Gerrit-Change-Number: 15023 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Jan 2020 00:30:41 +0000 Gerrit-HasComments: Yes
