Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 )
Change subject: IMPALA-9330: Resolve unmasked complex types in masked tables ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/15108/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15108/10//COMMIT_MSG@7 PS10, Line 7: es > nit: I would prefer to somehow make the first line shorter and add "+ enabl I mention enable column masking by default at line36. Do you mean also mentioning it in the title? http://gerrit.cloudera.org:8080/#/c/15108/10/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/15108/10/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@a75 PS10, Line 75: > The member became unused. Oops, missing it... -- To view, visit http://gerrit.cloudera.org:8080/15108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cc5565c64c1a4a56445b8edde59b1168f387791 Gerrit-Change-Number: 15108 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Feb 2020 14:06:24 +0000 Gerrit-HasComments: Yes
