wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15057 )
Change subject: IMPALA-9287: Add support for embedded HMS in CDP builds ...................................................................... Patch Set 12: (4 comments) Thanks for your review. And I've already fixed this as possible. http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15057/10//COMMIT_MSG@7 PS10, Line 7: IMPALA-9287: Add support for embedded HMS in CDP builds > I suggest modify the title of the JIRA which is more appropriate. Something Done http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1210 PS10, Line 1210: <!-- IMPALA-9287: Needed when catalogd used embedded HMS--> > Since we are removing the test scope this comment can be edited/removed. Done http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1214 PS10, Line 1214: <version>3.2.0-m3</version> > please add a <scope>runtime</scope> here, along with the comment pointing t Done http://gerrit.cloudera.org:8080/#/c/15057/10/fe/pom.xml@1233 PS10, Line 1233: <groupId>org.apache.hive</groupId> > can you add <scope>runtime</scope> here? Also, please add a comment as to w Done -- To view, visit http://gerrit.cloudera.org:8080/15057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc7d7e30cd560d43bb707dec54f4494355809f66 Gerrit-Change-Number: 15057 Gerrit-PatchSet: 12 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Thu, 06 Feb 2020 08:54:15 +0000 Gerrit-HasComments: Yes
