Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15186 )
Change subject: IMPALA-9366: Remove embedded pointer reference in PhjBuilder::CodegenInsertRuntimeFilters ...................................................................... Patch Set 1: (1 comment) I checked the other callers of CastPtrToLlvmPtr() to make sure they were all pointers to ScalarExpr instead of per-finstance objects. CastPtrToLlvmPtr() is still an anti-pattern and an obstacle to things like codegen caching, but we don't need to fix it right now. Maybe file a follow-on JIRA to remove it entirely? Also I'd often ask for perf benchmarking for changes like this, but we've done this transformation often enough that I'm confident it won't make a difference perf-wise. http://gerrit.cloudera.org:8080/#/c/15186/1/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/15186/1/be/src/exec/partitioned-hash-join-builder.cc@638 PS1, Line 638: FilterContext filter_ctxs[], TupleRow* build_row) noexcept { DCHECK that filter_ctx is referring to the same array as filter_ctx_? -- To view, visit http://gerrit.cloudera.org:8080/15186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09037b5832b037536bde9324f7a2a10778511114 Gerrit-Change-Number: 15186 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Feb 2020 21:55:41 +0000 Gerrit-HasComments: Yes
