Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15169 )
Change subject: IMPALA-8960 (prep 1): Copy Kudu cache code to be/src/util/cache ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache-bench.cc File be/src/util/cache/cache-bench.cc: http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache-bench.cc@176 PS3, Line 176: pair<int64_t, int64_t> hits_lookups = RunQueryThreads(FLAGS_num_threads, FLAGS_run_seconds); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache-bench.cc@183 PS3, Line 183: LOG(INFO) << test_case << ": " << HumanReadableNum::ToString(l_per_sec) << " lookups/sec"; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache-bench.cc@184 PS3, Line 184: LOG(INFO) << test_case << ": " << StringPrintf("%.1f", hit_rate * 100.0) << "% hit rate"; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache.h File be/src/util/cache/cache.h: http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache.h@127 PS3, Line 127: // Passing EXPECT_IN_CACHE will increment the hit/miss metrics that track the number of times line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache.h@128 PS3, Line 128: // blocks were requested that the users were hoping to get the block from the cache, along with line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/cache.h@131 PS3, Line 131: // This helps in determining if we are effectively caching the blocks that matter the most. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/nvm_cache.cc File be/src/util/cache/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/nvm_cache.cc@8 PS3, Line 8: // This file implements a cache based on the MEMKIND library (http://memkind.github.io/memkind/) line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/nvm_cache.cc@9 PS3, Line 9: // This library makes it easy to program against persistent memory hardware by exposing an API line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/15169/3/be/src/util/cache/nvm_cache.cc@706 PS3, Line 706: int err = CALL_MEMKIND(memkind_create_pmem, FLAGS_nvm_cache_path.c_str(), capacity, &vmp); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/15169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7b8b852b56613803dea125456fa9e8b3736d76 Gerrit-Change-Number: 15169 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Feb 2020 23:46:44 +0000 Gerrit-HasComments: Yes
