Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: IMPALA-8800: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc File be/src/exec/kudu-util.cc: http://gerrit.cloudera.org:8080/#/c/14705/13/be/src/exec/kudu-util.cc@135 PS13, Line 135: Invalid DateValue" > Any chance to output the value for troubleshooting? We generally do not return values in error messages to avoid leaking sensitive information. Adding the name of the column would be nice though. http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@387 PS13, Line 387: create table Can you also add tests where we insert to / select from such a table? http://gerrit.cloudera.org:8080/#/c/14705/13/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@391 PS13, Line 391: 1970-01-01 The Unix epoch is a quite unfortunate test value in my opinion, as both dates and int64 timestamps represent it as 0. -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 13 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Feb 2020 11:21:57 +0000 Gerrit-HasComments: Yes
