Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13806 )
Change subject: IMPALA-6663: Expose current DDL metrics on WebUI ...................................................................... Patch Set 13: (4 comments) Only found a few nits, other then that LGTM http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogDdlCounter.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogDdlCounter.java: http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogDdlCounter.java@34 PS13, Line 34: super(); I think it's implicitly called by Java. http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationCounter.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationCounter.java: http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationCounter.java@39 PS13, Line 39: AtomicLong nit: since everything is in 'synchronized' I think a simple Long is enough http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationCounter.java@77 PS13, Line 77: summarizTable.javaes typos http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogResetMetadataCounter.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogResetMetadataCounter.java: http://gerrit.cloudera.org:8080/#/c/13806/13/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogResetMetadataCounter.java@65 PS13, Line 65: Optional<TTableName> tTableName = : req.table_name != null ? Optional.of(req.table_name) : Optional.empty(); : if (req.is_refresh) { : decrementCounter(ResetMetadataType.REFRESH.toString(), getTableName(tTableName)); : } else if (tTableName.isPresent()) { : decrementCounter( : ResetMetadataType.INVALIDATE_METADATA.toString(), getTableName(tTableName)); : } else { : decrementCounter(ResetMetadataType.INVALIDATE_METADATA_GLOBAL.toString(), : getTableName(tTableName)); nit: this is mostly duplicated from increment. Seems like it wouldn't be too much effort to refactor the duplicated parts into a helper method. -- To view, visit http://gerrit.cloudera.org:8080/13806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ed76f134bad6d3b3d4dce132365a53a01e9512a Gerrit-Change-Number: 13806 Gerrit-PatchSet: 13 Gerrit-Owner: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 11 Feb 2020 13:33:39 +0000 Gerrit-HasComments: Yes
