Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15123 )
Change subject: IMPALA-7002: Throw AuthorizationException when user accesses non-existent table/database in CTE without required privileges. ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/15123/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/15123/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@606 PS11, Line 606: authorize("with t as (select nocol from functional.alltypes) select * from t") : .error(selectError("functional.alltypes")); > also run this with privileges on all columns except for the non existing co will add a new test case with required privileges for all existing columns. http://gerrit.cloudera.org:8080/#/c/15123/11/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@609 PS11, Line 609: // In the following query, the number of explicit column labels in With clause : // is greater than the number of columns in the view statement. It will trigger : // analysis exception when register local view during analysis. This test case : // verify that authorization exception will be thrown if user don't have privilege : // to execute SELECT on the column. > // With clause column labels exceeding the number of columns in the query. will fix the comments -- To view, visit http://gerrit.cloudera.org:8080/15123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6b657a7147a136198a9a97a679c9131ee814577 Gerrit-Change-Number: 15123 Gerrit-PatchSet: 11 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Feb 2020 21:58:07 +0000 Gerrit-HasComments: Yes
