Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks ...................................................................... Patch Set 8: Code-Review+1 (1 comment) This looks good to me. One small comment. http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc File be/src/runtime/bufferpool/buffer-allocator.cc: http://gerrit.cloudera.org:8080/#/c/15208/8/be/src/runtime/bufferpool/buffer-allocator.cc@82 PS8, Line 82: Uses std::unique_lock instead of : /// std::unique_lock because it is movable. This comment stops making sense. -- To view, visit http://gerrit.cloudera.org:8080/15208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f Gerrit-Change-Number: 15208 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2020 18:14:41 +0000 Gerrit-HasComments: Yes
