Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15208 )
Change subject: IMPALA-8013: switch from boost to std locks ...................................................................... IMPALA-8013: switch from boost to std locks The locks are mostly drop-in replacements that wrap the same pthread implementations. I went through all of the boost mutex/lock/thread-related includes and updated them so that the boost mutex headers are not pulled in. E.g. <boost/thread.hpp> is an uber-header that pulls in *all* of the boost mutex and thread headers. std::shared_lock doesn't exist until c++17, so we don't replace this. Compile Time: I confirmed that preprocessed files got slightly shorter, which translated into a slight compile time improvement for a full build. Before: real 9m27.502s user 64m39.775s sys 2m49.002s After: real 9m19.071s user 63m13.950s sys 2m45.066s Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f Reviewed-on: http://gerrit.cloudera.org:8080/15208 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/benchmarks/free-lists-benchmark.cc M be/src/benchmarks/lock-benchmark.cc M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M be/src/codegen/codegen-symbol-emitter.cc M be/src/codegen/codegen-symbol-emitter.h M be/src/codegen/instruction-counter-test.cc M be/src/codegen/llvm-codegen.cc M be/src/common/atomic-test.cc M be/src/common/logging.cc M be/src/common/names.h M be/src/common/object-pool.h M be/src/exec/blocking-join-node.h M be/src/exec/blocking-plan-root-sink.cc M be/src/exec/blocking-plan-root-sink.h M be/src/exec/buffered-plan-root-sink.h M be/src/exec/external-data-source-executor.cc M be/src/exec/hbase-table-writer.h M be/src/exec/hdfs-scan-node-base.h M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scan-node.h M be/src/exec/join-builder.h M be/src/exec/kudu-scan-node.h M be/src/exec/partitioned-hash-join-node.h M be/src/exec/plan-root-sink.cc M be/src/rpc/auth-provider.h M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/rpc/rpc-trace.h M be/src/rpc/thrift-server.cc M be/src/rpc/thrift-server.h M be/src/rpc/thrift-util.cc M be/src/runtime/bufferpool/buffer-allocator.cc M be/src/runtime/bufferpool/buffer-allocator.h M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/runtime/bufferpool/free-list.h M be/src/runtime/bufferpool/reservation-tracker.cc M be/src/runtime/bufferpool/reservation-tracker.h M be/src/runtime/client-cache.h M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator-filter-state.h M be/src/runtime/coordinator.h M be/src/runtime/dml-exec-state.cc M be/src/runtime/dml-exec-state.h M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-instance-state.h M be/src/runtime/hbase-table-factory.cc M be/src/runtime/hbase-table-factory.h M be/src/runtime/hbase-table.h M be/src/runtime/hdfs-fs-cache.cc M be/src/runtime/hdfs-fs-cache.h M be/src/runtime/initial-reservations.cc M be/src/runtime/io/disk-io-mgr-internal.h M be/src/runtime/io/disk-io-mgr-stress.cc M be/src/runtime/io/disk-io-mgr-stress.h M be/src/runtime/io/disk-io-mgr.h M be/src/runtime/io/handle-cache.h M be/src/runtime/io/handle-cache.inline.h M be/src/runtime/io/request-context.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/runtime/krpc-data-stream-mgr.cc M be/src/runtime/krpc-data-stream-mgr.h M be/src/runtime/krpc-data-stream-recvr.cc M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/lib-cache.cc M be/src/runtime/lib-cache.h M be/src/runtime/mem-tracker.h M be/src/runtime/query-state.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-filter-bank.h M be/src/runtime/runtime-filter.h M be/src/runtime/runtime-filter.inline.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/scanner-mem-limiter.cc M be/src/runtime/sorted-run-merger.h M be/src/runtime/sorter.cc M be/src/runtime/thread-resource-mgr.cc M be/src/runtime/thread-resource-mgr.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M be/src/scheduling/cluster-membership-mgr.h M be/src/scheduling/scheduler.h M be/src/service/child-query.h M be/src/service/client-request-state.h M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.h M be/src/statestore/failure-detector.cc M be/src/statestore/failure-detector.h M be/src/statestore/statestore-subscriber.cc M be/src/statestore/statestore-subscriber.h M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M be/src/testutil/impalad-query-executor.h M be/src/transport/TSaslServerTransport.cpp M be/src/transport/TSaslServerTransport.h M be/src/util/blocking-queue-test.cc M be/src/util/blocking-queue.h M be/src/util/collection-metrics.h M be/src/util/condition-variable.h M be/src/util/cyclic-barrier-test.cc M be/src/util/cyclic-barrier.cc M be/src/util/cyclic-barrier.h M be/src/util/hdfs-bulk-ops.h M be/src/util/histogram-metric.h M be/src/util/internal-queue-test.cc M be/src/util/internal-queue.h M be/src/util/memory-metrics.cc M be/src/util/memory-metrics.h M be/src/util/metrics.h M be/src/util/periodic-counter-updater.h M be/src/util/promise-test.cc M be/src/util/promise.h M be/src/util/runtime-profile-counters.h M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h M be/src/util/sharded-query-map-util.h M be/src/util/simple-logger.cc M be/src/util/simple-logger.h M be/src/util/stopwatch.h M be/src/util/thread-pool-test.cc M be/src/util/thread-pool.h M be/src/util/thread.h M be/src/util/webserver.cc 133 files changed, 330 insertions(+), 367 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I81d37490d05049919270eb6406fb3d787f78f92f Gerrit-Change-Number: 15208 Gerrit-PatchSet: 13 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
