Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15301
Change subject: IMPALA-9423: Add keys to cookie components ...................................................................... IMPALA-9423: Add keys to cookie components Impala's HTTP authentication cookie format is similar, but not identical, to the format used by other Hadoop components. This has caused us some problems when other Hadoop systems make assumptions about the cookie format. In particular, KNOX-2223 made a change to Apache Knox's cookie handling that works for cookies generated by Hive and HDFS but breaks cookie handling for Impala when requests are proxied through Knox. This match modifies our cookie format slightly to more closely resemble Hive and HDFS's format by adding keys to the individual components of the cookie value, fixing the regression caused by KNOX-2223 and hopefully reducing the probability of another such regression being introduced in the future. Testing: - Ran existing cookie auth tests. Updated one test to fix an issue introduced by IMPALA-8899 where we were no longer testing what we thought we were. - Manualy tested in a cluster with Apache Knox. Change-Id: I73f37a4c4f28edf35f4b8195d3f03a2f178f3d0b --- M be/src/rpc/cookie-util.cc M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java 2 files changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/15301/1 -- To view, visit http://gerrit.cloudera.org:8080/15301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73f37a4c4f28edf35f4b8195d3f03a2f178f3d0b Gerrit-Change-Number: 15301 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
