Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15104 )
Change subject: IMPALA-9228: ORC scanner reads rows into scratch batch ...................................................................... Patch Set 8: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/15104/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15104/5//COMMIT_MSG@20 PS5, Line 20: Note, typo: testing http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-columnar-scanner-ir.cc File be/src/exec/hdfs-columnar-scanner-ir.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-columnar-scanner-ir.cc@23 PS5, Line 23: scratch_batch_ nit: the != nullptr in written out in most of Impala http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/hdfs-orc-scanner.cc@702 PS5, Line 702: nit: the != nullptr in written out in most of Impala http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/15104/5/be/src/exec/orc-column-readers.cc@264 PS5, Line 264: >col_id_path_map_[ Can you mention it in the commit message that no scratch batch is used if there are collections? This will lead to also not having codegen in this case if the we want to use the same functions as Parquet, which always uses scratch batches. -- To view, visit http://gerrit.cloudera.org:8080/15104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56db0325dee283d73742ebbae412d19693fac0ca Gerrit-Change-Number: 15104 Gerrit-PatchSet: 8 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Mar 2020 15:30:11 +0000 Gerrit-HasComments: Yes
