Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15322 )
Change subject: IMPALA-4080 [part 6]: Move codegen from join's exec node to plan node and from data sinks to their config classes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15322/1/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/15322/1/be/src/exec/partitioned-hash-join-builder.cc@1162 PS1, Line 1162: codegen, true, *hash_table_config_, &eval_build_row_fn)); > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/15322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fe54b4040d6e3c2fc224f7cd6c8c0bfe813707a Gerrit-Change-Number: 15322 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Mar 2020 19:32:44 +0000 Gerrit-HasComments: Yes
