Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15219 )
Change subject: IMPALA-9384: Improve Impala shell usability by enabling live_progress in interactive mode ...................................................................... Patch Set 3: (3 comments) I have nits about commit message only, will let David look at code http://gerrit.cloudera.org:8080/#/c/15219/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15219/3//COMMIT_MSG@9 PS3, Line 9: In order to improve usability, this patch would like to make Impala shell show query The commit message describes the change. So "this patch makes Impala Shell show ..." http://gerrit.cloudera.org:8080/#/c/15219/3//COMMIT_MSG@11 PS3, Line 11: live_progress by default when a user launches impala shell in the interactive mode. Nit: in general, unless you have some special text, you should word wrap at 72 chars in a commit message http://gerrit.cloudera.org:8080/#/c/15219/3//COMMIT_MSG@14 PS3, Line 14: live_progress by either using the proposed command line flag or setting the option as Don't say 'proposed' the commit message describes what changed. -- To view, visit http://gerrit.cloudera.org:8080/15219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3765b775f663fa227e59728acffe4d5ea9a5e2d3 Gerrit-Change-Number: 15219 Gerrit-PatchSet: 3 Gerrit-Owner: Alice Fan <fan...@gmail.com> Gerrit-Reviewer: Alice Fan <fan...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Mar 2020 18:05:09 +0000 Gerrit-HasComments: Yes
