Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/15281 )
Change subject: IMPALA-4080 [part 3]: Moved codegen code for TupleRowComparator into a Config object ...................................................................... Patch Set 4: (1 comment) Rebased and resolved conflicts with IMPALA-8755 (http://gerrit.cloudera.org:8080/14080) @Norbert or @Zoltan can any one of you please take a quick look since you are the owner/reviewed the patch for IMPALA-8755. Thanks http://gerrit.cloudera.org:8080/#/c/15281/3/be/src/util/tuple-row-compare.h File be/src/util/tuple-row-compare.h: http://gerrit.cloudera.org:8080/#/c/15281/3/be/src/util/tuple-row-compare.h@164 PS3, Line 164: > Could be const ref as the bool->int8_t conversion is done in TupleRowCompar Done -- To view, visit http://gerrit.cloudera.org:8080/15281 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I265604ecbae2c80ff59e697fddfeea4976b25cd9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Mar 2020 20:00:00 +0000 Gerrit-HasComments: Yes
