Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/15332 )
Change subject: IMPALA-7686: Allow RANGE() clause before HASH() clause for PARTITION BY ...................................................................... Patch Set 4: (2 comments) Minor nits again. I'll +2 if these are covered http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@123 PS4, Line 123: swapped nit: Swapped http://gerrit.cloudera.org:8080/#/c/15332/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@128 PS4, Line 128: swapped nit: this word is not needed (and doesn't really makes sense here) -- To view, visit http://gerrit.cloudera.org:8080/15332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I914e340e9acfb0f49c7d4f78705dbd9bde0aec8c Gerrit-Change-Number: 15332 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Mar 2020 07:47:56 +0000 Gerrit-HasComments: Yes
