Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/15260 )
Change subject: IMPALA-9357: Fix race condition in alter_database event ...................................................................... IMPALA-9357: Fix race condition in alter_database event The race condition is exposed intermittently, on certain builds which causes test_event_processing::test_self_events test to fail. This happens because we are checking for self-event identifiers in the Db object without taking a lock. When a DDL like 'comment on database is 'test'' is executed, it is possible that the event processor thread is triggered as soon as the ALTER_DATABASE event is generated. This may cause event processor fail the self-event detection since the self-event identifiers are not yet added to the Db object. The fix adds a Db lock similar to Table lock. Alter db operations in CatalogOpExecutor now take db locks instead of metastoreDdlLock_ which makes it consistent with table locking protocol. Testing: 1. Ran existing tests for events processor. 2. This test was failing on centos6 frequently (failed in 1/3 times). After the fix I ran the test in a loop for 24 hrs (197 iterations) and the test didn't fail. 3. Ran core tests with CDP and CDH builds. Change-Id: I472fd8a55740769ee5cdb84e48422a4ab39a8d1e --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/Db.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M tests/custom_cluster/test_event_processing.py 5 files changed, 170 insertions(+), 106 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/15260/5 -- To view, visit http://gerrit.cloudera.org:8080/15260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I472fd8a55740769ee5cdb84e48422a4ab39a8d1e Gerrit-Change-Number: 15260 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
