David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15378 )
Change subject: IMPALA-9466: impala-shell client retry for hs2-http protocol ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/15378/7/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/15378/7/tests/custom_cluster/test_hs2_fault_injection.py@123 PS7, Line 123: @pytest.mark.execute_serially > you could probably use a separate connection for each test, but I guess eit For what it's worth, it seems that all of the custom cluster are serial, because a key feature of that test suite is that they restart the cluster -- I don't recall the exactly frequency, but it might be with each test? So parallel tests would step all over each other. Which leads me to wonder -- admittedly naively -- why are these custom cluster tests? Sorry if this should be obvious. The faults are being injected artificially, right -- they appear as faults to the client, but the cluster isn't really being affected? I may totally be misreading these. -- To view, visit http://gerrit.cloudera.org:8080/15378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da9e9e8d34a340eaf763397cc095ff6260d65d5 Gerrit-Change-Number: 15378 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Mar 2020 20:36:13 +0000 Gerrit-HasComments: Yes