Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15505 )
Change subject: IMPALA-9191 (part 1): Allow Impala to run tests without Sentry ...................................................................... Patch Set 4: (1 comment) This all looks good to me. One small comment. http://gerrit.cloudera.org:8080/#/c/15505/4/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/15505/4/bin/impala-config.sh@247 PS4, Line 247: export DISABLE_SENTRY="true" Let's provide a way to override this value with an environment variable. i.e. a developer could specify DISABLE_SENTRY_OVERRIDE=false in bin/impala-config-branch.sh and we would respect it. -- To view, visit http://gerrit.cloudera.org:8080/15505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3f1840a77a7b32310a5c8b78a2c26300ccb41e Gerrit-Change-Number: 15505 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Mar 2020 23:22:42 +0000 Gerrit-HasComments: Yes
