David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15537 )
Change subject: IMPALA-9107: Add timestamp to maven logging options. ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9107: Add timestamp to maven log > I think we can re-use IMPALA-9107 as the jira. Done http://gerrit.cloudera.org:8080/#/c/15537/1//COMMIT_MSG@9 PS1, Line 9: We found that using awk to add a timestamp to the maven log can fail : if gawk is not installed. It seems better to configure maven to add : the timestamp itself. > Please add a small snippet of what the maven output looks like with a times Done http://gerrit.cloudera.org:8080/#/c/15537/1/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/15537/1/bin/impala-config.sh@328 PS1, Line 328: export IMPALA_MAVEN_OPTIONS=${IMPALA_MAVEN_OPTIONS-} : : # If enabled, debug symbols are added to cross-comp > We set IMPALA_MAVEN_OPTIONS in the environment to allow different settings Maybe it's better to just to this at the same place in mvn-quiet.sh? LOGGING_OPTIONS = -Dorg.slf4j.simpleLogger.showDateTime DATETIME_FORMAT = -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss if ! mvn -B $IMPALA_MAVEN_OPTIONS $LOGGING_OPTIONS $LOGGING_OPTIONS "$@" | \ tee -a "$LOG_FILE" | grep -E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test; then echo "mvn $IMPALA_MAVEN_OPTIONS $@ exited with code $?" exit 1 fi http://gerrit.cloudera.org:8080/#/c/15537/1/bin/mvn-quiet.sh File bin/mvn-quiet.sh: http://gerrit.cloudera.org:8080/#/c/15537/1/bin/mvn-quiet.sh@35 PS1, Line 35: DATETIME_FORMAT = -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss > Keep the -B Doh. Sorry. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/15537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10fbe9eb76b66e6ba00db9f95c91063410dd1b4e Gerrit-Change-Number: 15537 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Mar 2020 00:27:23 +0000 Gerrit-HasComments: Yes
