Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15214 )

Change subject: IMPALA-8870: Bump up guava version from 14.0.1 to 28.1-jre
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15214/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15214/8//COMMIT_MSG@17
PS8, Line 17: DISABLE_SENTRY
Please also mention this in the first line.


http://gerrit.cloudera.org:8080/#/c/15214/8//COMMIT_MSG@19
PS8, Line 19: and thus run-sentry-service.sh cannot be successfully executed.
Can you add some more information about this? For example:
- This disables every Sentry related test.
- The plan is to remove Sentry support in the Impala 4 line. Since Impala 3.4 
was recently branched, it is ok to break Sentry from now on.



--
To view, visit http://gerrit.cloudera.org:8080/15214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9690a926953a8d3c3872277680b4be0551546c68
Gerrit-Change-Number: 15214
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Mar 2020 23:58:32 +0000
Gerrit-HasComments: Yes

Reply via email to