Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14197 )
Change subject: IMPALA-5092 Add support for VARCHAR in Kudu tables ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/14197/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14197/14//COMMIT_MSG@33 PS14, Line 33: * Manually reproduced a check failure due to multi-byte characters : and tested that length truncation resolve that issue. > I will look at implementing it. The main challenge is inserting data direct We have a bunch of tests in test_kudu.py that already directly use the Kudu python client to simulate situations where an external client has done something we don't expect, so hopefully you should be able to do the same thing. http://gerrit.cloudera.org:8080/#/c/14197/14//COMMIT_MSG@47 PS14, Line 47: support > I am under the impression they should work (given it's just strings), but n My expectation is that yes, they should work with this patch as-is, but of course its definitely worth testing. -- To view, visit http://gerrit.cloudera.org:8080/14197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d4959410fdd882bfa980cb55e8a7837c7823da8 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 14 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 30 Mar 2020 22:10:08 +0000 Gerrit-HasComments: Yes
