Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15511 )
Change subject: WIP IMPALA-9434: Implement Robin Hood Hash Table. ...................................................................... Patch Set 9: (2 comments) Hi David, thank you for your feedback. Below is summary of Patch Set 6 to 9. Patch Set 6: - Create FLAGS_enable_robin_hood to enable Robin Hood hash table. - Create backend tests for Robin Hood hash table. Patch Set 7: - Fix clang-tidy warnings about tmp_bucket_ struct initialization. Patch Set 8: - Add MaxTravel profile counter Patch Set 9: - Add improvement to update probe stats just once prior to Probe return. http://gerrit.cloudera.org:8080/#/c/15511/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15511/7//COMMIT_MSG@8 PS7, Line 8: > I suggest we add an additional profile counter to capture the max travel di Done http://gerrit.cloudera.org:8080/#/c/15511/8/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: http://gerrit.cloudera.org:8080/#/c/15511/8/be/src/exec/hash-table.inline.h@97 PS8, Line 97: } > Minor optimization suggestion - you should be able to avoid recalculating t Done -- To view, visit http://gerrit.cloudera.org:8080/15511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28eeccd7f9ccae39e31972391f971901bcbfe986 Gerrit-Change-Number: 15511 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Mar 2020 18:20:55 +0000 Gerrit-HasComments: Yes
