Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15529 )
Change subject: IMPALA-8980: Remove functional*.alltypesinsert from EE tests ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15529/3/testdata/workloads/functional-query/queries/QueryTest/insert_null.test File testdata/workloads/functional-query/queries/QueryTest/insert_null.test: http://gerrit.cloudera.org:8080/#/c/15529/3/testdata/workloads/functional-query/queries/QueryTest/insert_null.test@11 PS3, Line 11: LOCATION 'hdfs://localhost:20500/test-warehouse/nullinsert'; The path should be created inside the uniquedb, so it should be /test-warehouse/{uniquqdbname}.db/nullinsert . In the current setup running the same test with different parameters can interfere due to using the same path. Another issue is that the current path would only work on hdfs but not with s3/adsl There are some macros to help with this situation: '$FILESYSTEM_PREFIX/test-warehouse/$DATABASE.db/nullinsert' would instantiate the correct values. http://gerrit.cloudera.org:8080/#/c/15529/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/15529/3/tests/common/impala_test_suite.py@895 PS3, Line 895: def __drop_partitions(self, db_name, table_name): This can be also removed. http://gerrit.cloudera.org:8080/#/c/15529/3/tests/common/impala_test_suite.py@907 PS3, Line 907: def __reset_table(self, db_name, table_name): This can be also removed. http://gerrit.cloudera.org:8080/#/c/15529/3/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/15529/3/tests/query_test/test_insert.py@161 PS3, Line 161: @pytest.mark.execute_serially : @SkipIfNotHdfsMinicluster.tuned_for_minicluster : def test_insert_mem_limit(self, vector): : if (vector.get_value('table_format').file_format == 'parquet'): : vector.get_value('exec_option')['COMPRESSION_CODEC'] = \ : vector.get_value('compression_codec') : self.run_test_case('QueryTest/insert-mem-limit', vector, : multiple_impalad=vector.get_value('exec_option')['sync_ddl'] == 1) : # IMPALA-7023: These queries can linger and use up memory, causing subsequent : # tests to hit memory limits. Wait for some time to allow the query to : # be reclaimed. : verifiers = [MetricVerifier(i.service) : for i in ImpalaCluster.get_e2e_test_cluster().impalads] I think that unique_database is better here, but execute_serially is still needed due to the comment below. -- To view, visit http://gerrit.cloudera.org:8080/15529 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I257e936868917a2fcc6c030f6c855b247e8a0eea Gerrit-Change-Number: 15529 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Adam Tamas <ta...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Apr 2020 14:54:31 +0000 Gerrit-HasComments: Yes
