zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 )
Change subject: IMPALA-9428 Add arm64 atomic ops ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15300/18//COMMIT_MSG@13 PS18, Line 13: https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/google/protobuf/stubs/atomicops_internals_arm64_gcc.h > Ok cool, I did a diff against that version to review it. Hi, Tim. I agree with you very much, Ultimately we better update to use chromium's platform-independent version. -- To view, visit http://gerrit.cloudera.org:8080/15300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I469e0169193ad6ad8acca2a800c8b3f043083ddd Gerrit-Change-Number: 15300 Gerrit-PatchSet: 21 Gerrit-Owner: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Anonymous Coward <zhaoren...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Apr 2020 01:56:29 +0000 Gerrit-HasComments: Yes
