Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15653 )
Change subject: IMPALA-9602: Fix case-sensitivity for local catalog ...................................................................... IMPALA-9602: Fix case-sensitivity for local catalog This patch makes the database and table names lower-case when doing lookups, insertion and invalidations of database objects or table objects in the local catalog cache. The remote catalog already does the right thing by lower-casing these names, so this patch makes the behavior consistent with what the remote catalog does. Testing: - Added unit tests for CatalogdMetaProvider by examining cache hits and misses when loading and invalidating database or tables with upper-case names. - Manually tested as follows: start Impala with local catalog enabled start-impala-cluster.py --catalogd_args="--catalog_topic_mode=minimal" --impalad_args="--use_local_catalog=true" Create database in lower-case: "CREATE DATABASE db1;" Run the following a few times (this errors without the patch): impala-shell.sh -q "DROP TABLE IF EXISTS DB1.ddl_test1 PURGE; CREATE TABLE DB1.ddl_test1 (val string);" Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26 Reviewed-on: http://gerrit.cloudera.org:8080/15653 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java 2 files changed, 65 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f368fa9b50e22ec5057d0bf66c3fd51064d4c26 Gerrit-Change-Number: 15653 Gerrit-PatchSet: 6 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>