Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 )
Change subject: IMPALA-9626: Use Python from the toolchain for Impala ...................................................................... Patch Set 15: Code-Review+1 (2 comments) Carry +1 from Tim http://gerrit.cloudera.org:8080/#/c/15624/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15624/11//COMMIT_MSG@7 PS11, Line 7: IMPALA-9626: Use Python from the toolchain for Impala > I think this is significant enough to deserve a JIRA. I filed IMPALA-9626 Thank you. Added the Jira reference to the commit message. http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: http://gerrit.cloudera.org:8080/#/c/15624/6/infra/python/bootstrap_virtualenv.py@211 PS6, Line 211: : def install_deps(): > Thanks for the explanation. I think have a marginal preference for placing Done -- To view, visit http://gerrit.cloudera.org:8080/15624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7b40cef89cfb3b467b61b2d54a94e708642882b Gerrit-Change-Number: 15624 Gerrit-PatchSet: 15 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 10 Apr 2020 17:37:21 +0000 Gerrit-HasComments: Yes
